Sending large HTTP POST inside run() with requests package

techdiverdown · July 1, 2021, 4:55pm

Question about sending http post with large body via run() and using requests versus core.http. We noted that it fails using the run method with http requests and it works with the core.http. By failure i mean it runs and we see defunct processes eventually. We jacked the action timeout way up…but it never returns from run. Can someone explain why these 2 methods behave differently and when one should use the core.http versus run with requests. When i say large the body is about 2K lines of JSON.

devdude · July 9, 2021, 4:26pm

ST2 3.5 fix???

github.com/StackStorm/st2

Fix subprocess handling when killed on timeout

StackStorm:master ← r0m4n-z:fix_zombie_spawning_green_shell

opened 11:20PM - 03 Apr 21 UTC

r0m4n-z

+392 -10

**Problem:** Running ST2 actions as subprocesses (`eventlet.green`) spawns zomb…ies on timeout. **Reproduce:** 1. Spawn process which execution is going to take more than command's timeout. 2. `process.kill()` will be called. 3. Spawned process becomes zombie. Method `process.kill()` is never handled as well as `process.communicate()`, which calls `process.wait()` - all those methods check `process.returncode` against None and if `returncode` already set, it just will be returned. Why do I suggest to remove line 170: it doesn't seem to be necessary to set returncode here to avoid race condition for some `kill_func`. Probably additional custom attribute could be used here on `process` to provide that information if it's really necessary, but I don't think ST2 should do that.